[Maxima] [Maxima-commits] CVS: maxima/src sin.lisp,1.25,1.26
dtc at scieneer.com
Wed May 9 20:12:09 CDT 2007
Raymond Toy wrote:
> Andreas Eder wrote:
>> Update of /cvsroot/maxima/maxima/src
>> In directory sc8-pr-cvs16:/tmp/cvs-serv8722/src
>> Modified Files:
>> Log Message:
>> replaced use of concat with gentemp
>> - (concat '$integrationconstant
>> - (incf $integration_constant_counter)))))
>> + (gentemp "$INTEGRATIONCONSTANT"))))
> I think this is wrong. integration_constant_counter is a documented
> variable. This used to do something with it. Now it doesn't and you
> get some random integer appended to integrationconstant.
The change is not 'case clean' and will not work as intended on a lower
case variant of CL. At a minimum this would need to be rewritten as:
(gentemp (symbol-name '$integrationconstant))
I notice there have been a few other changes along these lines that also
introduce case issues, such as (concat '$errexp symbol-number) =>
(intern (format nil "$ERREXP~D" symbol-number))
which would at a minimum need to be rewritten as:
(intern (format nil "~A~D" '$errexp symbol-number))
These changes need to be reworked to make them 'case clean', so perhaps
it would be best to just revert to the use of 'concat in this instance?
Andreas, are you reviewing these changes, or can I proceed to patch or
revert any case related issues?
I do appreciate many of the changes you are making. However, personally
the use of 'concat and accessor functions like 'pt-red seems appropriate.
One code style issue that I would like to see changed is the excessive use
of &aux variables which is probably just a legacy of the original code base.
Also use of consistent comment prefixes, following CLtL guidelines:
;;;; major code comment, ;;; outside functions, ;; inside functions, and
; at the end of lines.
More information about the Maxima