[Maxima] Comments about FFT PATCH ready
ziga.lenarcic at gmail.com
Tue Sep 8 12:48:53 CDT 2009
On Sep 8, 2009, at 7:08 PM, Raymond Toy wrote:
> Žiga Lenarčič wrote:
>> It works nicely with 'flonum', yes. I changed it to use add and mul,
>> added your changes from CVS, used flonum instead of double-float...
>> See the attached file.
> These changes have been committed, more or less. I made a few small
> changes to match Lisp style better, and to make sure fft-dif-internal
> gets the correct initial values for the general flonum type.
> I ran rtest_fft, and all tests pass, whatever that means.
On a side note, fft.usg is rather outdated and it's perhaps
unnecessary to have user documentation in two places (I would simply
remove it). fft.dem is outdated also - it can be either removed or
updated (if anybody even looks at these .dem, it's been broken for
some time but no complaints from the users).
I could rewrite it, but I think it's better to accumulate examples
and documentation in one place - Maxima's documentation (that's where
the user looks, generally). fft's docs could be expanded with some
examples.. again I could do that when I have time.
More information about the Maxima